vvcephei commented on a change in pull request #8716:
URL: https://github.com/apache/kafka/pull/8716#discussion_r429352661
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java
##########
@@ -359,6 +359,10 @@ private AssignmentConfigs(final StreamsConfig configs) {
final Integer maxWarmupReplicas,
final Integer numStandbyReplicas,
final Long probingRebalanceIntervalMs) {
+ if (maxWarmupReplicas < 1) {
+ throw new IllegalArgumentException("must configure at least
one warmup replica");
+ }
+
Review comment:
I added this constraint to mirror the constraint we already apply in
StreamConfig. It's not critical, but I was disappointed that I had written a
bunch of tests that included a technically invalid configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
