[GitHub] [kafka] cadonna commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

[GitBox]

cadonna commented on a change in pull request #8697:
URL: https://github.com/apache/kafka/pull/8697#discussion_r429904772



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##########
@@ -642,6 +651,55 @@ public static void addAvgAndMaxToSensor(final Sensor 
sensor,
         );
     }
 
+    public static void addMinAndMaxAndP99AndP90ToSensor(final Sensor sensor,

Review comment:
       req: Please add unit tests in `StreamsMetricsImplTest`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org