rajinisivaram commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-633934633
@ijuma By not updating `completedReceives` when the channel is closed, we retain a reference to the channel until the next `poll()`. In terms of receives themselves, there is no impact. Looking at the code again, it seems unnecessary to use KafkaChannel as the key for the receive map. Like all other maps in Selector that store poll state for the channel, we can use the channel id instead. Updated the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
