chia7712 commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r431002494
##########
File path: core/src/main/scala/kafka/coordinator/group/DelayedJoin.scala
##########
@@ -33,11 +33,15 @@ import scala.math.{max, min}
*/
private[group] class DelayedJoin(coordinator: GroupCoordinator,
group: GroupMetadata,
- rebalanceTimeout: Long) extends
DelayedOperation(rebalanceTimeout, Some(group.lock)) {
+ rebalanceTimeout: Long) extends
DelayedOperation(rebalanceTimeout, None) {
- override def tryComplete(): Boolean = coordinator.tryCompleteJoin(group,
forceComplete _)
- override def onExpiration() = coordinator.onExpireJoin()
- override def onComplete() = coordinator.onCompleteJoin(group)
+ /**
+ * It controls the lock manually since GroupCoordinator#onCompleteJoin()
invoked by onComplete() can't be within a
+ * group lock since GroupCoordinator#onCompleteJoin() tries to complete
delayed requests.
+ */
+ override def tryComplete(): Boolean = if
(group.inLock(group.hasAllMembersJoined)) forceComplete() else false
Review comment:
> I am thinking that we could do the following.
Copy that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
