ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r431484939
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java
##########
@@ -189,38 +190,52 @@ private void prepareClose(final boolean clean) {
@Override
public void closeClean(final Map<TopicPartition, Long> checkpoint) {
Objects.requireNonNull(checkpoint);
- close(true);
+ close(true, false);
log.info("Closed clean");
}
@Override
public void closeDirty() {
- close(false);
+ close(false, false);
log.info("Closed dirty");
}
- private void close(final boolean clean) {
+ @Override
+ public void closeAndRecycleState() {
+ prepareClose(true);
+ close(true, true);
Review comment:
Well, I think it still makes sense to have `closeDirty` and `closeClean`
fall back to the same `close` method since the only difference is whether to
rethrow exceptions, whereas `closeAndRecycle` actually has different contents.
But I guess for that reason right there it makes sense to duplicate only the
relevant parts of `close`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
