[GitHub] [kafka] ijuma commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

[GitBox]

ijuma commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r431576336



##########
File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java
##########
@@ -22,7 +22,8 @@
 
     DEFAULT("default"),
     USE_ALL_DNS_IPS("use_all_dns_ips"),
-    
RESOLVE_CANONICAL_BOOTSTRAP_SERVERS_ONLY("resolve_canonical_bootstrap_servers_only");
+    
RESOLVE_CANONICAL_BOOTSTRAP_SERVERS_ONLY("resolve_canonical_bootstrap_servers_only"),
+    USE_FIRST_DNS_IP("use_first_dns_ip");

Review comment:
       Thinking about it, maybe we should not add this at all. We could 
deprecate `default` and switch the config default to `use_all_dns_ips`. 
Thoughts @badaiaqrandista and @rajinisivaram?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org