kowshik commented on a change in pull request #8680:
URL: https://github.com/apache/kafka/pull/8680#discussion_r427827018



##########
File path: core/src/main/scala/kafka/server/FinalizedFeatureCache.scala
##########
@@ -0,0 +1,93 @@
+package kafka.server
+
+import kafka.utils.Logging
+import org.apache.kafka.common.feature.{Features, VersionLevelRange}
+
+// Raised whenever there was an error in updating the FinalizedFeatureCache 
with features.

Review comment:
       As we discussed offline today, this exception is already handled in 
`ChangeNotificationProcessorThread.doWork()` method defined in 
`FinalizedFeatureChangeListener.scala`. Basically, the ZK change notification 
processor thread exits the Broker with a fatal error (non-zero exit code) when 
this exception (or any exception) is caught while trying to update 
`FinalizedFeatureCache`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to