ijuma commented on a change in pull request #8605:
URL: https://github.com/apache/kafka/pull/8605#discussion_r432864648
##########
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##########
@@ -681,4 +683,15 @@ public void testDiff() {
assertThat(diff, is(mkSet("a", "b")));
assertThat(diff.getClass(), equalTo(TreeSet.class));
}
+
+ @Test
+ public void testPropsToMap() {
+ Properties props = new Properties();
+ props.put(1, 2);
+ assertThrows(ConfigException.class, () -> Utils.propsToMap(props));
+ props.remove(1);
+ // the non-string value is legal
+ props.put("key", 22);
+ assertEquals(Utils.propsToMap(props).get("key"), 22);
Review comment:
Should we assert a string valued parameter too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
