[GitHub] [kafka] feyman2016 commented on a change in pull request #8760: Kafka-10064 Add documentation for KIP-571

[GitBox]

feyman2016 commented on a change in pull request #8760:
URL: https://github.com/apache/kafka/pull/8760#discussion_r432951034



##########
File path: docs/streams/developer-guide/app-reset-tool.html
##########
@@ -56,7 +56,8 @@
         <dl class="docutils">
             <dt>Prerequisites</dt>
             <dd><ul class="first last">
-                <li><p class="first">All instances of your application must be 
stopped. Otherwise, the application may enter an invalid state, crash, or 
produce incorrect results. You can verify whether the consumer group with ID 
<code class="docutils literal"><span class="pre">application.id</span></code> 
is still active by using <code class="docutils literal"><span 
class="pre">bin/kafka-consumer-groups</span></code>.</p>
+                <li><p class="first">All instances of your application must be 
stopped. Otherwise, the application may enter an invalid state, crash, or 
produce incorrect results. You can verify whether the consumer group with ID 
<code class="docutils literal"><span class="pre">application.id</span></code> 
is still active by using <code class="docutils literal"><span 
class="pre">bin/kafka-consumer-groups</span></code>.
+                    When long session timeout has been configured, active 
members could take longer to get expired on the broker thus blocking the reset 
job to complete. Use the <code class="docutils literal"><span 
class="pre">--force</span></code> option could remove those left-over members 
immediately.</p>

Review comment:
       @abbccdda Screenshots as below, please kindly check, thanks!
   <img width="1280" alt="屏幕快照 2020-05-31 下午10 04 30" 
src="https://user-images.githubusercontent.com/23044946/83354407-ff2a5480-a38a-11ea-9ccb-7b1df4b98210.png";>
   <img width="1280" alt="屏幕快照 2020-05-31 下午10 00 02" 
src="https://user-images.githubusercontent.com/23044946/83354324-862afd00-a38a-11ea-998d-b7cd268a55c0.png";>
   <img width="1280" alt="屏幕快照 2020-05-31 下午10 07 23" 
src="https://user-images.githubusercontent.com/23044946/83354434-2c770280-a38b-11ea-87b3-0e968b9dbee1.png";>
   
   

##########
File path: docs/streams/developer-guide/app-reset-tool.html
##########
@@ -56,7 +56,8 @@
         <dl class="docutils">
             <dt>Prerequisites</dt>
             <dd><ul class="first last">
-                <li><p class="first">All instances of your application must be 
stopped. Otherwise, the application may enter an invalid state, crash, or 
produce incorrect results. You can verify whether the consumer group with ID 
<code class="docutils literal"><span class="pre">application.id</span></code> 
is still active by using <code class="docutils literal"><span 
class="pre">bin/kafka-consumer-groups</span></code>.</p>
+                <li><p class="first">All instances of your application must be 
stopped. Otherwise, the application may enter an invalid state, crash, or 
produce incorrect results. You can verify whether the consumer group with ID 
<code class="docutils literal"><span class="pre">application.id</span></code> 
is still active by using <code class="docutils literal"><span 
class="pre">bin/kafka-consumer-groups</span></code>.
+                    When long session timeout has been configured, active 
members could take longer to get expired on the broker thus blocking the reset 
job to complete. Use the <code class="docutils literal"><span 
class="pre">--force</span></code> option could remove those left-over members 
immediately.</p>

Review comment:
       Fixed
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org