bellemare commented on a change in pull request #8764:
URL: https://github.com/apache/kafka/pull/8764#discussion_r433486418
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java
##########
@@ -66,10 +66,13 @@ public void init(final InternalProcessorContext context) {
valSerializer = (Serializer<V>) context.valueSerde().serializer();
}
- // if value serializers are internal wrapping serializers that may
need to be given the default serializer
+ // if serializers are internal wrapping serializers that may need to
be given the default serializer
// then pass it the default one from the context
if (valSerializer instanceof WrappingNullableSerializer) {
- ((WrappingNullableSerializer)
valSerializer).setIfUnset(context.valueSerde().serializer());
+ ((WrappingNullableSerializer) valSerializer).setIfUnset(
Review comment:
@guozhangwang This is 1/2 of the areas that needed the fix. The
valueSerde was being passed into the underlying Serde, despite it really
needing the keySerde.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/SourceNode.java
##########
@@ -87,10 +87,13 @@ public void init(final InternalProcessorContext context) {
this.valDeserializer = (Deserializer<V>)
context.valueSerde().deserializer();
}
- // if value deserializers are internal wrapping deserializers that may
need to be given the default
+ // if deserializers are internal wrapping deserializers that may need
to be given the default
// then pass it the default one from the context
if (valDeserializer instanceof WrappingNullableDeserializer) {
- ((WrappingNullableDeserializer)
valDeserializer).setIfUnset(context.valueSerde().deserializer());
+ ((WrappingNullableDeserializer) valDeserializer).setIfUnset(
Review comment:
@guozhangwang This is 2/2 of the areas that needed the fix. Same thing,
the valueSerde was being passed into the underlying Serde, despite it really
needing the keySerde.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
