hachikuji commented on a change in pull request #8784:
URL: https://github.com/apache/kafka/pull/8784#discussion_r434122555
##########
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##########
@@ -89,7 +89,7 @@ class GroupMetadataManager(brokerId: Int,
private val openGroupsForProducer = mutable.HashMap[Long,
mutable.Set[String]]()
/* setup metrics*/
- val partitionLoadSensor = metrics.sensor("PartitionLoadTime")
+ private val partitionLoadSensor = metrics.sensor("GroupPartitionLoadTime")
Review comment:
nit: maybe we may as well add constant names for this as well as the
metric group?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
