[GitHub] [kafka] hachikuji commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

[GitBox]

hachikuji commented on a change in pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#discussion_r434761114



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##########
@@ -827,14 +827,15 @@ public void onSuccess(OffsetForEpochResult offsetsResult) 
{
                                     "Failed leader offset epoch validation for 
" + requestPosition
                                         + " since no end offset larger than 
current fetch epoch was reported");
                             } catch (OffsetOutOfRangeException e) {
-                                // Swallow the OffsetOutOfRangeException to 
finish all partitions validation.
+                                setFatalOffsetForLeaderException(e);

Review comment:
       Can we fix the LogTruncationException case below as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org