[ 
https://issues.apache.org/jira/browse/KAFKA-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126412#comment-17126412
 ] 

Chia-Ping Tsai commented on KAFKA-10090:
----------------------------------------

It seems to me that the PR should include following changes.

1. 
[ChannelBuilders#channelBuilderConfigs|https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java#L162]
 should not return copy of configs.

2. verify the unused keys (see 
https://github.com/apache/kafka/blob/trunk/clients/src/test/java/org/apache/kafka/common/network/ChannelBuildersTest.java#L71)

[~rwruck] Feel free to file a PR to resolve this issue. The PR is able to bring 
more discussion :)



> Misleading warnings: The configuration was supplied but isn't a known config
> ----------------------------------------------------------------------------
>
>                 Key: KAFKA-10090
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10090
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 2.5.0
>            Reporter: Robert Wruck
>            Priority: Major
>
> In our setup (using Spring cloud stream Kafka binder), we see log messages 
> like:
>  
> {{The configuration 'ssl.keystore.password' was supplied but isn't a known 
> config}}
>  
> logged by org.apache.kafka.clients.admin.AdminClientConfig. The Kafka binder 
> actually uses SSL and security.protocol is set to SSL.
> Looking through the code, a few things seem odd:
>  * The log message says "isn't a known config" but that's not true. It is 
> *known*, i.e. defined in ConfigDef, but not *used*.
>  * The method for detecting whether a config is actually *used* is not 
> complete. ChannelBuilders.channelBuilderConfigs() for example extracts the 
> configs to use for the created channel builder using *new 
> HashMap(config.values())* thus *get()* won't mark a config as used anymore.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to