abbccdda commented on a change in pull request #8803:
URL: https://github.com/apache/kafka/pull/8803#discussion_r436125793
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##########
@@ -167,12 +195,36 @@ public String toString() {
* @return A string representation of this instance.
*/
public String toString(final String indent) {
Review comment:
I prefer we get a newbie ticket to test out this logic in a unit test
case.
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -495,12 +496,9 @@ public void closeDirty() {
}
@Override
- public void update(final Set<TopicPartition> topicPartitions, final
ProcessorTopology processorTopology) {
- super.update(topicPartitions, processorTopology);
+ public void update(final Set<TopicPartition> topicPartitions, final
Map<String, List<String>> nodeToSourceTopics) {
Review comment:
Could we add a unit test in `StreamTaskTest`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
