abbccdda commented on a change in pull request #8845:
URL: https://github.com/apache/kafka/pull/8845#discussion_r438320972
##########
File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala
##########
@@ -232,12 +232,12 @@ object ConsumerPerformance extends LazyLogging {
.describedAs("size")
.ofType(classOf[java.lang.Integer])
.defaultsTo(2 * 1024 * 1024)
- val numThreadsOpt = parser.accepts("threads", "Number of processing
threads.")
+ val numThreadsOpt = parser.accepts("threads", "Number of processing
threads. It has not been implemented.")
Review comment:
+1
##########
File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala
##########
@@ -256,6 +256,10 @@ object ConsumerPerformance extends LazyLogging {
.defaultsTo(10000)
options = parser.parse(args: _*)
+
+ if(options.has(numThreadsOpt) || options.has(numFetchersOpt))
+ println("WARNING: option threads and num-fetch-threads has not been
implemented.")
Review comment:
`has not been implemented` -> `have been deprecated`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
