ijuma commented on a change in pull request #8841:
URL: https://github.com/apache/kafka/pull/8841#discussion_r438346871
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##########
@@ -978,7 +1000,7 @@ public boolean hasValidPosition() {
@Override
public boolean hasPosition() {
Review comment:
It's a bit weird to add a comment here and not elsewhere. It looks like
a clear bug since `hasValidPosition` returns `false`. Generally, comments are
useful when it's not obvious. What kind of clarification would you like to see?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
