vvcephei commented on a change in pull request #8818:
URL: https://github.com/apache/kafka/pull/8818#discussion_r438420120
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##########
@@ -1634,16 +1636,15 @@ public void
shouldReturnInterleavedAssignmentWithUnrevokedPartitionsRemovedWhenN
// The new consumer's assignment should be empty until c1 has the
chance to revoke its partitions/tasks
assertThat(assignment.get(CONSUMER_2).partitions(),
equalTo(emptyList()));
- assertThat(
- AssignmentInfo.decode(assignment.get(CONSUMER_2).userData()),
- equalTo(new AssignmentInfo(
- LATEST_SUPPORTED_VERSION,
- emptyList(),
- emptyMap(),
- emptyMap(),
- emptyMap(),
- 0
- )));
+
+ final AssignmentInfo actualAssignment =
AssignmentInfo.decode(assignment.get(CONSUMER_2).userData());
+ assertThat(actualAssignment.version(), is(LATEST_SUPPORTED_VERSION));
+ assertThat(actualAssignment.activeTasks(), empty());
+ // Note we're not asserting anything about standbys. If the assignor
gave an active task to CONSUMER_2, it would
+ // be converted to a standby, but we don't know whether the assignor
will do that.
Review comment:
The StreamsPartitionAssignor is independent of the TaskAssignor
implementation, so the StreamsPartitionAssignorTest should make minimal
assumptions about what the default TaskAssignor implementation will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
