aakashnshah edited a comment on pull request #8829:
URL: https://github.com/apache/kafka/pull/8829#issuecomment-642299655


   I've added a condition to `WorkerSinkTask` in `deliverMessages()` to throw a 
`ConnectException` if the Errant Record Reporter to account for the case that 
the developer swallows the exception thrown from `executeFailed(...)` within 
`put(...)`. Right now, I am storing this information (whether an exception must 
be thrown and the exception to throw) within `WorkerErrantRecordReporter`, let 
me know if you guys think this is a good idea of it would be better done within 
`RetryWithToleranceOperator`. @rhauch @wicknicks 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to