d8tltanc commented on a change in pull request #8683:
URL: https://github.com/apache/kafka/pull/8683#discussion_r439752541
##########
File path:
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java
##########
@@ -296,36 +314,6 @@ public AuthenticationException
authenticationException(String id) {
return state != null ? state.authenticationException : null;
}
- /**
- * Resets the failure count for a node and sets the reconnect backoff to
the base
- * value configured via reconnect.backoff.ms
- *
- * @param nodeState The node state object to update
- */
- private void resetReconnectBackoff(NodeConnectionState nodeState) {
Review comment:
Including all types of reset together is probably not a good choice
because the reset of failed attempts and the reset of the connection timeout
may happen in different places.
However, I agree we should have some abstraction on the update and reset
logic. I'll put the logic in new class methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
