d8tltanc commented on a change in pull request #8683: URL: https://github.com/apache/kafka/pull/8683#discussion_r442375424
########## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ########## @@ -786,6 +808,29 @@ private void handleAbortedSends(List<ClientResponse> responses) { abortedSends.clear(); } + /** + * Handle socket channel connection timeout. The timeout will hit iff a connection + * stays at the ConnectionState.CONNECTING state longer than the timeout value, + * as indicated by ClusterConnectionStates.NodeConnectionState. + * + * @param responses The list of responses to update + * @param now The current time + */ + private void handleTimeoutConnections(List<ClientResponse> responses, long now) { + Set<String> connectingNodes = connectionStates.connectingNodes(); + for (String nodeId: connectingNodes) { Review comment: Refactored ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org