guozhangwang commented on a change in pull request #8896:
URL: https://github.com/apache/kafka/pull/8896#discussion_r443004192
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##########
@@ -458,9 +462,48 @@ public void restore() {
}
maybeUpdateLimitOffsetsForStandbyChangelogs();
+
+ maybeLogRestorationProgress();
+ }
+ }
+
+ private void maybeLogRestorationProgress() {
+ if (state == ChangelogReaderState.ACTIVE_RESTORING) {
+ if (time.milliseconds() - lastRestoreLogTime >
RESTORE_LOG_INTERVAL_MS) {
+ final Set<TopicPartition> topicPartitions =
activeRestoringChangelogs();
+ if (!topicPartitions.isEmpty()) {
+ final StringBuilder builder = new
StringBuilder().append("Restoration in progress for ")
+
.append(topicPartitions.size())
+ .append("
partitions.");
+ for (final TopicPartition partition : topicPartitions) {
Review comment:
Actually I do have complaints about the StreamsPartitionAssignor log
entries haha :)
Anyways, I think `grep` a valid reason. My rationale was that when searching
for this entry, most people would use "Restoration in progress for" and then
manually check if the particular interested partition in the following line,
but I guess I'm just biased because I'm not a heavy grep user.
It is a quite nit comment and I won't feel strong about it. Your call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
