chia7712 commented on a change in pull request #8891:
URL: https://github.com/apache/kafka/pull/8891#discussion_r443220535
##########
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##########
@@ -962,22 +963,18 @@ object ReassignPartitionsCommand extends Logging {
verifyBrokerIds(adminClient, proposedParts.values.flatten.toSet)
val currentParts = getReplicaAssignmentForPartitions(adminClient,
proposedParts.keySet.toSet)
println(currentPartitionReplicaAssignmentToString(proposedParts,
currentParts))
- if (interBrokerThrottle >= 0 || logDirThrottle >= 0) {
+
+ if (interBrokerThrottle > 0 || logDirThrottle > 0) {
Review comment:
It does nothing now when the value is equal to 0. Does it break
compatibility (Although we had said that ``` The throttle rate should be at
least 1 KB/s.```)? By contrast, the new method ```modifyInterBrokerThrottle```
send request even if the value is 0. why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
