[GitHub] [kafka] C0urante commented on a change in pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

[GitBox]

C0urante commented on a change in pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#discussion_r443742947



##########
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java
##########
@@ -289,7 +285,6 @@ public void startConnector(
                 // Can't be put in a finally block because it needs to be 
swapped before the call on
                 // statusListener
                 Plugins.compareAndSwapLoaders(savedLoader);
-                workerMetricsGroup.recordConnectorStartupFailure();

Review comment:
       Oooh, yeah that's neat. 👍 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org