[GitHub] [kafka] mimaison commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

[GitBox]

mimaison commented on a change in pull request #7577:
URL: https://github.com/apache/kafka/pull/7577#discussion_r445443084



##########
File path: 
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java
##########
@@ -42,6 +47,7 @@
     private static final Logger log = 
LoggerFactory.getLogger(MirrorCheckpointTask.class);
 
     private AdminClient sourceAdminClient;
+    private AdminClient targetAdminClient;

Review comment:
       Can we use `Admin` instead of `AdminClient` for both of these?

##########
File path: 
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java
##########
@@ -94,6 +114,7 @@ public void stop() {
         Utils.closeQuietly(offsetSyncStore, "offset sync store");
         Utils.closeQuietly(sourceAdminClient, "source admin client");
         Utils.closeQuietly(metrics, "metrics");
+        Utils.closeQuietly(scheduler, "scheduler");

Review comment:
       We should also close `targetAdminClient`

##########
File path: 
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java
##########
@@ -61,16 +63,18 @@
     private static final int RECORD_TRANSFER_DURATION_MS = 10_000;
     private static final int CHECKPOINT_DURATION_MS = 20_000;
 
+    private SystemTime time = new SystemTime();

Review comment:
       Use `Time.SYSTEM` instead of creating a new instance




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org