[ 
https://issues.apache.org/jira/browse/KAFKA-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145783#comment-17145783
 ] 

Randall Hauch commented on KAFKA-10143:
---------------------------------------

This line appears in the `2.6` branch but does not appear in the `2.5` branch 
or the `2.5.0` tag, which means it only affects the `2.6.0` release. Updating 
the "Affects Version(s)" accordingly.

> Can no longer change replication throttle with reassignment tool
> ----------------------------------------------------------------
>
>                 Key: KAFKA-10143
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10143
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 2.6.0
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>            Priority: Blocker
>             Fix For: 2.6.0
>
>
> Previously we could use --execute with the --throttle option in order to 
> change the quota of an active reassignment. We seem to have lost this with 
> KIP-455. The code has the following comment:
> {code}
>     val reassignPartitionsInProgress = zkClient.reassignPartitionsInProgress()
>     if (reassignPartitionsInProgress) {
>       // Note: older versions of this tool would modify the broker quotas 
> here (but not
>       // topic quotas, for some reason).  This behavior wasn't documented in 
> the --execute
>       // command line help.  Since it might interfere with other ongoing 
> reassignments,
>       // this behavior was dropped as part of the KIP-455 changes.
>       throw new 
> TerseReassignmentFailureException(cannotExecuteBecauseOfExistingMessage)
>     }
> {code}
> Seems like it was a mistake to change this because it breaks compatibility. 
> We probably have to revert. At the same time, we can make the intent clearer 
> both in the code and in the command help output.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to