feyman2016 commented on pull request #8832:
URL: https://github.com/apache/kafka/pull/8832#issuecomment-650535027


   @abbccdda I merged the trunk and found that `StreamsPartitionAssignor` has 
been updated by other PRs so it's `ClassFanOutComplexity` goes up to 49, and it 
will definitely exceed the upper limit 50 with my change, so I just introduced 
an inner class `NumOfRepartitionsCalculator` to encapsulate the new algo to 
workaround the `ClassFanOutComplexity` limitation.
   Now we can come back to the most important issue I mentioned above, do we 
have the assumption that we won't have cycles in a graph built with 
`TopicsNode` and `TopicsInfoNode`? I will still try to find the answer for that 
but would be good if someone knows more details about it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to