[GitHub] [kafka] abbccdda commented on a change in pull request #8940: KAFKA-10181: AlterConfig/IncrementalAlterConfig should route to the controller for topic resource changes

[GitBox]

abbccdda commented on a change in pull request #8940:
URL: https://github.com/apache/kafka/pull/8940#discussion_r446710038



##########
File path: 
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -263,7 +267,7 @@ public void testGenerateClientId() {
         Set<String> ids = new HashSet<>();
         for (int i = 0; i < 10; i++) {
             String id = 
KafkaAdminClient.generateClientId(newConfMap(AdminClientConfig.CLIENT_ID_CONFIG,
 ""));
-            assertTrue("Got duplicate id " + id, !ids.contains(id));
+            assertFalse("Got duplicate id " + id, ids.contains(id));

Review comment:
       All changes in this file are side cleanups except in 
`testIncrementalAlterConfigs` and `testAlterConfigsUponNotController`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org