[ 
https://issues.apache.org/jira/browse/KAFKA-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147923#comment-17147923
 ] 

Lucas Bradstreet commented on KAFKA-10158:
------------------------------------------

[~chia7712] I'm quite sure what the right way to fix it is. I think if we 
produced messages in multiple batches, and set 

"replica.fetch.max.bytes" low enough it would ensure that the follower 
throttled itself prior to joining the ISR.

I think checking for the reassignment to complete before checking for under 
replicated partitions defeats the purpose of the test. I think the test was 
designed to show that in progress reassignments would not show up as URPs. I 
think the test could be improved by checking that a reassignment is still in 
progress at the end of the test, after the --under-replicated-partitions check 
is made.

> Fix flaky 
> kafka.admin.TopicCommandWithAdminClientTest#testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-10158
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10158
>             Project: Kafka
>          Issue Type: Bug
>          Components: unit tests
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>             Fix For: 2.7.0
>
>
> Altering the assignments is a async request so it is possible that the 
> reassignment is still in progress when we start to verify the 
> "under-replicated-partitions". In order to make it stable, it needs a wait 
> for the reassignment completion before verifying the topic command with 
> "under-replicated-partitions".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to