[GitHub] [kafka] tombentley commented on a change in pull request #8966: KAFKA-10220: add null check for configurationKey

[GitBox]

tombentley commented on a change in pull request #8966:
URL: https://github.com/apache/kafka/pull/8966#discussion_r448222519



##########
File path: core/src/main/scala/kafka/server/AdminManager.scala
##########
@@ -354,10 +354,13 @@ class AdminManager(val config: KafkaConfig,
       }
       def createResponseConfig(configs: Map[String, Any],
                                createConfigEntry: (String, Any) => 
DescribeConfigsResponseData.DescribeConfigsResourceResult): 
DescribeConfigsResponseData.DescribeConfigsResult = {
-        val filteredConfigPairs = configs.filter { case (configName, _) =>
-          /* Always returns true if configNames is None */
-          resource.configurationKeys.asScala.forall(_.contains(configName))
-        }.toBuffer
+        val filteredConfigPairs = if (resource.configurationKeys == null)
+          configs.toBuffer
+        else
+          configs.filter { case (configName, _) =>
+            /* Always returns true if configurationKeys is null */

Review comment:
       This comment is no longer valid




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org