ableegoldman commented on a change in pull request #8963:
URL: https://github.com/apache/kafka/pull/8963#discussion_r449219621
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##########
@@ -837,6 +866,11 @@ public void init(final ProcessorContext context) {
crash = errorInjectedClient2;
sharedCommit = commitCounterClient2;
}
+ punctuator = context.schedule(
Review comment:
Sort of; with eos-beta when you need to commit one task, you need to
commit all of them, so requesting a commit at all should be sufficient. It's
kind of a subtle point, but I think it's actually preferable to just request a
commit on one task so this test can also verify that we commit all tasks
together
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
