junrao commented on a change in pull request #8981:
URL: https://github.com/apache/kafka/pull/8981#discussion_r450430604
##########
File path: tests/kafkatest/tests/core/transactions_test.py
##########
@@ -53,7 +53,11 @@ def __init__(self, test_context):
self.zk = ZookeeperService(test_context, num_nodes=1)
self.kafka = KafkaService(test_context,
num_nodes=self.num_brokers,
- zk=self.zk)
+ zk=self.zk,
+ # Reducing timeout of transaction can
quickly cleanup the unstable offsets.
+ # IN hard_bounce mode, transaction is broke
ungracefully. Hence, it produces unstable
+ # offsets which obstructs
TransactionalMessageCopier from receiving position of group.
+ transaction_timeout=2000)
Review comment:
The default transaction.abort.timed.out.transaction.cleanup.interval.ms
is 10 secs. In the jira, the consumer seems to have failed without making
progress for 30 secs. So, will reducing this timeout help?
##########
File path: tests/kafkatest/tests/core/transactions_test.py
##########
@@ -53,7 +53,11 @@ def __init__(self, test_context):
self.zk = ZookeeperService(test_context, num_nodes=1)
self.kafka = KafkaService(test_context,
num_nodes=self.num_brokers,
- zk=self.zk)
+ zk=self.zk,
+ # Reducing timeout of transaction can
quickly cleanup the unstable offsets.
Review comment:
This is reducing the transaction cleanup interval.
##########
File path: tests/kafkatest/services/kafka/kafka.py
##########
@@ -101,7 +101,7 @@ def __init__(self, context, num_nodes, zk,
security_protocol=SecurityConfig.PLAI
jmx_attributes=None, zk_connect_timeout=5000,
zk_session_timeout=6000, server_prop_overides=None, zk_chroot=None,
zk_client_secure=False,
listener_security_config=ListenerSecurityConfig(),
per_node_server_prop_overrides=None,
- extra_kafka_opts="", tls_version=None):
+ extra_kafka_opts="", tls_version=None,
transaction_timeout=10000):
Review comment:
transaction_timeout => transaction_cleanup_interval?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
