Johnny-Malizia commented on a change in pull request #8936:
URL: https://github.com/apache/kafka/pull/8936#discussion_r451015408
##########
File path: core/src/main/scala/kafka/log/LogSegment.scala
##########
@@ -87,6 +87,12 @@ class LogSegment private[log] (val log: FileRecords,
// we will recover the segments above the recovery point in recoverLog()
// in any case so sanity checking them here is redundant.
txnIndex.sanityCheck()
+ // Failing to sanity check the timeIndex can result in a scenario where
log segments are
+ // prematurely deleted (before breaching retention periods) if the index
file was not resized
+ // to disk successfully.
+ // KAFKA-10207
+ timeIndex.sanityCheck()
+ offsetIndex.sanityCheck()
Review comment:
If the concern here is startup performance, we could instead fallback to
using the mtime of the file when the last offset and timestamp are both 0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
