wicknicks commented on a change in pull request #8918:
URL: https://github.com/apache/kafka/pull/8918#discussion_r451258641
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java
##########
@@ -343,7 +343,7 @@ private void doCommitSync(Map<TopicPartition,
OffsetAndMetadata> offsets, int se
}
private void doCommitAsync(Map<TopicPartition, OffsetAndMetadata> offsets,
final int seqno) {
- log.info("{} Committing offsets asynchronously using sequence number
{}: {}", this, seqno, offsets);
+ log.debug("{} Committing offsets asynchronously using sequence number
{}: {}", this, seqno, offsets);
Review comment:
these shouldn't be noisy. there is some [dedup
logic](https://github.com/apache/kafka/blob/2.5.0/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java#L430-L434)
that should prevent the same message from being printed over and over again.
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -475,7 +475,7 @@ private synchronized void recordSent(final
ProducerRecord<byte[], byte[]> record
public boolean commitOffsets() {
long commitTimeoutMs =
workerConfig.getLong(WorkerConfig.OFFSET_COMMIT_TIMEOUT_MS_CONFIG);
- log.info("{} Committing offsets", this);
+ log.debug("{} Committing offsets", this);
Review comment:
nit: since this is indicating entry into a method, I think it can be
trace level.
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##########
@@ -571,7 +571,7 @@ public boolean commitOffsets() {
finishSuccessfulFlush();
long durationMillis = time.milliseconds() - started;
recordCommitSuccess(durationMillis);
- log.info("{} Finished commitOffsets successfully in {} ms",
+ log.debug("{} Finished commitOffsets successfully in {} ms",
Review comment:
nit: since this is mostly indicating exit from the method, I think it
can be trace level too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
