rhauch commented on a change in pull request #8864:
URL: https://github.com/apache/kafka/pull/8864#discussion_r451856474
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java
##########
@@ -148,6 +148,7 @@ public KafkaStatusBackingStore(Time time, Converter
converter) {
this.statusTopic = statusTopic;
}
+ @SuppressWarnings("deprecation")
Review comment:
> Not sure if we should rewrite this test right away
First of all, this is not test code. It's actually part of the Connect
runtime.
Second, I'd have to look into what we would do differently and how we would
set `deliver.timeout.ms` to work with the existing logic that handles retries.
Since it's not clear, I suggest we keep the current behavior of setting
`retries=0` as long as that still function. We're using the
`ProducerConfig.RETRIES` constant, so that can't be removed without changing
this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
