vvcephei commented on a change in pull request #8994:
URL: https://github.com/apache/kafka/pull/8994#discussion_r451938891



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -95,7 +96,7 @@
      *          |      | Assigned (3)| <----+
      *          |      +-----+-------+      |
      *          |            |              |
-     *          |            |              |
+     *          |            |--------------+

Review comment:
       I meant to call this out, too. In order to get the task re-initialized 
after a corruption recovery, we could set the state back to PartitionsAssigned, 
but I felt that would be confusing in the logs. Instead, I added an extra 
condition that we'll initialize tasks if there are any that need 
initialization, even though the thread may already be in running, which means 
we can have a self-transition from running to running.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to