ableegoldman commented on a change in pull request #8996:
URL: https://github.com/apache/kafka/pull/8996#discussion_r452483525
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##########
@@ -222,8 +222,16 @@ void initializeStoreOffsetsFromCheckpoint(final boolean
storeDirIsEmpty) {
log.trace("Loaded offsets from the checkpoint file: {}",
loadedCheckpoints);
for (final StateStoreMetadata store : stores.values()) {
+ if (store.corrupted) {
+ log.error("Tried to initialize store offsets for corrupted
store {}", store);
+ throw new IllegalStateException("Should not initialize
offsets for a corrupted task");
+ }
+
if (store.changelogPartition == null) {
log.info("State store {} is not logged and hence would not
be restored", store.stateStore.name());
+ } else if (!store.stateStore.persistent()) {
Review comment:
I'm not sure I'd call it a spurious warning -- if we don't expect to
have checkpointed in-memory stores, and we happen to have an offset for one in
the checkpoint file, it seems reasonable to log a warning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
