[ https://issues.apache.org/jira/browse/KAFKA-10156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156720#comment-17156720 ]
Sergei commented on KAFKA-10156: -------------------------------- Not sure if that's the right way to go to avoid flaky test behavior, but I propose to also check for {{closingChannel(id)}} state in this test as there is potentially a code path that could lead to such state. PR link with proposed change: [https://github.com/apache/kafka/pull/9014]. Could please anyone have a look at it ([~ableegoldman]), and let me know your thoughts? I would like to continue on this one if chosen approach is considered to be okay or get some feedback on what else might be wrong. > Flaky Test SslSelectorTest.testCloseOldestConnection > ---------------------------------------------------- > > Key: KAFKA-10156 > URL: https://issues.apache.org/jira/browse/KAFKA-10156 > Project: Kafka > Issue Type: Bug > Components: network > Reporter: Sophie Blee-Goldman > Priority: Major > Labels: flaky-test > > Failed twice on the same build with > h3. Stacktrace > java.lang.AssertionError: The idle connection should have been closed at > org.junit.Assert.fail(Assert.java:89) at > org.junit.Assert.assertTrue(Assert.java:42) at > org.apache.kafka.common.network.SelectorTest.testCloseOldestConnection(SelectorTest.java:466) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.base/java.lang.reflect.Method.invoke(Method.java:566) at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) > at > org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at > java.base/java.lang.Thread.run(Thread.java:834) -- This message was sent by Atlassian Jira (v8.3.4#803005)