abbccdda commented on a change in pull request #9013:
URL: https://github.com/apache/kafka/pull/9013#discussion_r453913021
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##########
@@ -492,8 +492,19 @@ private static String parseAcks(String acksString) {
}
}
+ /**
+ * @deprecated Since 2.7.0. This will be removed in a future major release.
+ */
+ @Deprecated
public static Map<String, Object> addSerializerToConfig(Map<String,
Object> configs,
Serializer<?>
keySerializer, Serializer<?> valueSerializer) {
+ return appendSerializerToConfig(configs, keySerializer,
valueSerializer);
+ }
+
+ static Map<String, Object> appendSerializerToConfig(
+ Map<String, Object> configs,
Review comment:
nit: I don't feel strong about the style here, but maybe we should
consider align with other functions which has the first parameter on the same
line with function name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
