rajinisivaram commented on a change in pull request #9030:
URL: https://github.com/apache/kafka/pull/9030#discussion_r455916021
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/DescribeClientQuotasResponse.java
##########
@@ -66,10 +66,11 @@ public DescribeClientQuotasResponse(Map<ClientQuotaEntity,
Map<String, Double>>
}
public DescribeClientQuotasResponse(int throttleTimeMs, Throwable e) {
+ ApiError apiError = ApiError.fromThrowable(e);
Review comment:
@rondagostino Thanks for the review. Updated
`AlterClientQuotasResponse`. I think IncrementalAlterConfigsResponse is ok
since it uses ApiError, we create the error with the right message when
converting from Throwable. Can you just verify that the method with ApiError
was the one you meant? Thanks,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
