omkreddy edited a comment on pull request #8312: URL: https://github.com/apache/kafka/pull/8312#issuecomment-660478715
@tombentley After this change, `adminClient.describeConnfigs()` is not backward compatible with older kafka broker versions. It seems, older brokers are receiving empty configNames [here](https://github.com/apache/kafka/blob/2.5/core/src/main/scala/kafka/server/AdminManager.scala#L355). Older brokers expect `Option.None` value. Due to this old brokers are returning empty config list. We may need to explicitly set `setConfigurationKeys(null)` [here](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L1952). We also need to update ClientCompatibilityTest, to catch these kind of errors. https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/ClientCompatibilityTest.java https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/client/client_compatibility_features_test.py Let me know, if you can help with the fix. cc @mimaison ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
