kkonstantine commented on pull request #9040: URL: https://github.com/apache/kafka/pull/9040#issuecomment-661228560
Thanks for the fix @gharris1727. It's good to stabilize these tests, they've been relatively flaky for some time. W/r/t the actual fix I have to notice that we've been moving away from assertions that depend on log messages for some time. Yet, if that's the only way to stabilize these tests maybe we can maintain an exception here. Having said that, I'm curious why a stable group with all the members joined makes this test successful? I'd imagine that this would not be a requirement (a cluster with 1 worker is as good as a cluster with 3 workers module capacity requirements which these tests should not assert on). There might be value in retaining our expectations while the workers group is formed, because assuming things work only with a stable full group might make us miss bugs in during phases of failure and recovery. If your investigation revealed some more specific reasons around why these tests were flaky while the group was forming, it'd be good to know. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
