mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459205933
##########
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##########
@@ -1249,11 +1248,7 @@ public void cleanUp() {
log.debug("Current changelog positions: {}", allChangelogPositions);
final Map<TopicPartition, ListOffsetsResultInfo> allEndOffsets;
- try {
- allEndOffsets = fetchEndOffsets(allPartitions, adminClient);
- } catch (final TimeoutException e) {
- throw new StreamsException("Timed out obtaining end offsets from
kafka", e);
- }
+ allEndOffsets = fetchEndOffsets(allPartitions, adminClient);
Review comment:
Minor side fix: `fetchEndOffset` can never throw `TimeoutException`
because it catches all `RuntimeException` and convert them into
`StreamsException` already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
