[GitHub] [kafka] abbccdda commented on a change in pull request #8512: KAFKA-6024: Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

[GitBox]

abbccdda commented on a change in pull request #8512:
URL: https://github.com/apache/kafka/pull/8512#discussion_r459648674



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java
##########
@@ -1388,9 +1388,9 @@ public void commitSync() {
      */
     @Override
     public void commitSync(Duration timeout) {
+        maybeThrowInvalidGroupIdException();

Review comment:
       If we throw here, we will not execute the current `finally` block to 
call `release()`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org