vitojeng commented on a change in pull request #9069:
URL: https://github.com/apache/kafka/pull/9069#discussion_r459805054



##########
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##########
@@ -693,6 +695,16 @@ public void 
shouldNotGetQueryMetadataWithPartitionerWhenNotRunningOrRebalancing(
         streams.queryMetadataForKey("store", "key", (topic, key, value, 
numPartitions) -> 0);
     }
 
+    @Test(expected = UnknownStateStoreException.class)

Review comment:
       I am not sure if using annotation is a good choice. Would it be better 
to use `assertThrows` ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to