[
https://issues.apache.org/jira/browse/KAFKA-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166142#comment-17166142
]
Matthias J. Sax commented on KAFKA-10316:
-----------------------------------------
Sure, feel free to pick it up. Your understanding is correct. Let us know if
you have any further question about the ticket of the KIP process.
For testing, the general approach is to duplicate the tests in question to keep
testing deprecated API until it is removed. However, for this particular case,
there is not much to be tested, as it's very simple getters. Thus, I think we
don't need any additional tests, but existing tests that use the current method
can just be updated to use the new methods.
> Consider renaming getter method for Interactive Queries
> -------------------------------------------------------
>
> Key: KAFKA-10316
> URL: https://issues.apache.org/jira/browse/KAFKA-10316
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Priority: Minor
> Labels: beginner, need-kip, newbie
>
> In the 2.5 release, we introduce new classes for Interactive Queries via
> KIP-535 (cf https://issues.apache.org/jira/browse/KAFKA-6144). The KIP did
> not specify the names for getter methods of `KeyQueryMetadata` explicitly and
> they were added in the PR as `getActiveHost()`, `getStandbyHosts()`, and
> `getPartition()`.
> However, in Kafka it is custom to not use the `get` prefix for getters and
> thus the methods should have been added as `activeHost()`, `standbyHosts()`,
> and `partition()`, respectively.
> We should consider renaming the methods accordingly, by deprecating the
> existing ones and adding the new ones in parallel.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
