dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r465257558
##########
File path: core/src/main/scala/kafka/server/AdminManager.scala
##########
@@ -431,6 +433,26 @@ class AdminManager(val config: KafkaConfig,
(name, value) => new
DescribeConfigsResponseData.DescribeConfigsResourceResult().setName(name)
.setValue(value.toString).setConfigSource(ConfigSource.DYNAMIC_BROKER_LOGGER_CONFIG.id)
.setIsSensitive(false).setReadOnly(false).setSynonyms(List.empty.asJava))
+ case ConfigResource.Type.CLIENT =>
+ val clientId = resource.resourceName
+ val defaultProps =
adminZkClient.fetchEntityConfig(ConfigType.Client, ConfigEntityName.Default)
+ val clientProps =
adminZkClient.fetchEntityConfig(ConfigType.Client, if (clientId.isEmpty)
ConfigEntityName.Default else clientId)
+ val overlayedProps = new Properties()
+ overlayedProps.putAll(defaultProps)
+ overlayedProps.putAll(clientProps)
+ val configMap = overlayedProps.stringPropertyNames.asScala
+ .filter(ClientConfigs.isClientConfig).map{key => (key ->
overlayedProps.getProperty(key))}.toMap
Review comment:
```
if (ClientConfigs.isClientConfig(key) {
Some(key -> value)
} else {
None
}
```
Want to keep the client configs and discard the quotas.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
