johnthotekat commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-669664246
> @johnthotekat Some testa are know to be flaky and we try to work on them to avoid those build issues. It's constant effort to keep the build stable. Will trigger a new Jenkins run and can merge after it passed. > > I also saw that you merge changes from `trunk` and pushed an update. As long as there a not merge conflicts, this is not necessary. It also "invalidates" the Jenkins test result and we need to rerun Jenkins. Thus, only push new stuff into the PR if necessary. Otherwise, the merging gets delayed unnecessarily. (Also note, the "Retest this please" comments are not for you -- they trigger Jenkins (if Jenkins cooperates...) to rerun and you can ignore those comments). I did a pull to my branch just to make sure that my branch has all the recent changes (reason behind is the flaky test and I saw the PR for that flaky fix) and that's how that merge from `trunk` came in. I made sure it didn't have any conflicts. I'll make a note of your point. Thanks. And I really thought you put in the comments "Retest this please". :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
