vvcephei commented on a change in pull request #9073:
URL: https://github.com/apache/kafka/pull/9073#discussion_r467975526



##########
File path: build.gradle
##########
@@ -1266,6 +1266,27 @@ project(':streams') {
     if( !generatedDocsDir.exists() ) { generatedDocsDir.mkdirs() }
     standardOutput = new File(generatedDocsDir, 
"streams_config.html").newOutputStream()
   }
+
+  task testAll(
+    dependsOn: [
+            ':streams:test',
+            ':streams:test-utils:test',
+            ':streams:streams-scala:test',
+            ':streams:upgrade-system-tests-0100:test',
+            ':streams:upgrade-system-tests-0101:test',
+            ':streams:upgrade-system-tests-0102:test',
+            ':streams:upgrade-system-tests-0110:test',
+            ':streams:upgrade-system-tests-10:test',
+            ':streams:upgrade-system-tests-11:test',
+            ':streams:upgrade-system-tests-20:test',
+            ':streams:upgrade-system-tests-21:test',
+            ':streams:upgrade-system-tests-22:test',
+            ':streams:upgrade-system-tests-23:test',
+            ':streams:upgrade-system-tests-24:test',
+            ':streams:upgrade-system-tests-25:test',

Review comment:
       Thanks for the comment anyway.
   
   I was on the fence about it, but I went with including these projects just 
to be sure that `testAll` really tests all of the components of `:streams`. 
Even though they don't have tests, the `:test` target is convenient because it 
runs all of the compilation targets, as well as spotbugs and checkstyle. The 
idea is just to flush out any/all possible sources of failure so that we can be 
pretty sure that if `:streams:testAll` passes, then so will Jenkins.
   
   I agree it's a pain. Maybe we can consider either contributing a script to 
keep this stuff updated or writing some gradle code to build the list 
automatically.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to