cmccabe commented on pull request #9166: URL: https://github.com/apache/kafka/pull/9166#issuecomment-672338336
Thanks. This is one of those rare PRs where I really don't have any comments on how the code could be better. I do think we should do a round-trip test with the JSON converter as well, but that's out of scope for this change. Also, I should note that I am working on separating out the JSON stuff into a helper class. I think we may want to do this for the Struct stuff as well. Or at least provide some option to not generate the Struct stuff in cases where we don't need the legacy methods (like in the KIP-500 generated messages). But again, that's out of scope for this change. LGTM. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
