lbradstreet commented on a change in pull request #9147: URL: https://github.com/apache/kafka/pull/9147#discussion_r468940704
########## File path: tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java ########## @@ -284,7 +296,7 @@ public static void main(String[] args) { String consumerGroup = parsedArgs.getString("consumerGroup"); - final KafkaProducer<String, String> producer = createProducer(parsedArgs); + AtomicReference<KafkaProducer<String, String>> producer = new AtomicReference<>(createProducer(parsedArgs)); Review comment: volatiles can't be local. Arguably this could get refactored a little bit if we don't want to call get everywhere. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org